Add compare_python_gen helper. #1236
Merged
+140
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
changed the title
goodov
force-pushed
the
compare_python_gen
branch
from
97ce157
to
7bd0c1a
Compare
atuchin-m
reviewed
Oct 23, 2024
| @@ -13,17 +13,19 @@ export default function createCommand() { | |||
| .description('Compare two seed.bin') | |||
| .argument('<seed1_file>', 'seed1 file') | |||
| .argument('<seed2_file>', 'seed2 file') | |||
| .argument('<seed1_serialnumber>', 'seed1 serialnumber file') | |||
There was a problem hiding this comment.
Could we make these params optional? Otherwise it's a command not for humans, but for tests: normally just have two binary files to compare.
Maybe it makes sense to add show_serial command instead?
There was a problem hiding this comment.
made the serialnumber files optional.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
atuchin-m
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper command to run both python and TS generators to compare their outputs.
Tested on staging CI runs https://ci.brave.com/job/brave-browser-variations-publish-staging/1997/