Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BraveRoundTimeStamps Release 25% #1223

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Disable BraveRoundTimeStamps Release 25% #1223

merged 1 commit into from
Oct 10, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Oct 10, 2024 •
edited
Loading

For #1214

According to backtrace.io data disabling the feature helps:
Default (95%), ebc44611-ca7d8d80, still crashes on Spotify:
https://share.backtrace.io/api/share/5yTIx1x1ZTzUOoi6K0VApLn3

Disabled (5%), ebc44611-3d47f4f4, only few crashes a day, no RequestIdeCallback crashes:
https://share.backtrace.io/api/share/HWOa9G64FZWfx3SLx1Ks8hg2

@atuchin-m atuchin-m self-assigned this Oct 10, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner October 10, 2024 10:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1223.
    Android: Set the command line to --variations-pr=1223 in debug menu, restart the browser.
    iOS: Set Variations PR to 1223 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1223@be0a11f90310c5e414d83f53a099b7e2501fddd7
Uploaded Thu, 10 Oct 2024 10:37:09 GMT
PR commit 1bfdc7a
Base commit 1907c66
Merge commit be0a11f
Serial number 9143e6121671212570340f94917538e9

kjozwiak
kjozwiak approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 672717d Oct 10, 2024
7 checks passed
@kjozwiak kjozwiak deleted the disable-BraveRoundTimeStamps-release-25% branch October 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@atuchin-m atuchin-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atuchin-m @kjozwiak