Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BraveWorkaroundNewWindowFlash 100% Release. #1219

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Enable BraveWorkaroundNewWindowFlash 100% Release. #1219

merged 1 commit into from
Oct 8, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 8, 2024

1.70.x is now Release, so we can continue rolling this feature. It's already enabled by default in Nightly and Beta.

Related #1178

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1219.
    Android: Set the command line to --variations-pr=1219 in debug menu, restart the browser.
    iOS: Set Variations PR to 1219 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1219@057d2fe0074d04ba0bc89f22b36f35934a8459f2
Uploaded Tue, 08 Oct 2024 11:54:02 GMT
PR commit 6aea8d6
Base commit c6c765b
Merge commit 057d2fe
Serial number d7333024d9284c23c9349ccafe3c9c8c

@goodov goodov marked this pull request as ready for review October 8, 2024 11:56
@goodov goodov requested a review from a team as a code owner October 8, 2024 11:56
kjozwiak
kjozwiak approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 5288755 Oct 8, 2024
7 checks passed
@kjozwiak kjozwiak deleted the new-findow-flash-release branch October 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @kjozwiak