Update Brave Talk study to be in Release #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
reviewed
Sep 22, 2021
| @@ -913,7 +913,7 @@ | |||
| } | |||
| ], | |||
| "filter": { | |||
| "channel": ["BETA", "NIGHTLY"], | |||
There was a problem hiding this comment.
typically we should specify min_version, to not enable it for old clients @bsclifton @rebron
There was a problem hiding this comment.
@iefremov can we get this fixed or is it too late at this point? What would happen if a client that ended up pulling the above study doesn't meet the new requirements. Would it simply be removed? Assuming it wouldn't cause any issues for users that meet the requirements and have the study?
I'll make sure we have a min_version next time 👍
There was a problem hiding this comment.
Thanks for the heads up - will do that going forward. No action needed for this, AFAIK. But they would be shown as being in an experiment which isn't applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per today's triage (Sep 7th), here's the uplift for Talk to RELEASE channel
cc: @jsecretan for the go-ahead. Was uplifted / tested against staging here:
#93