Add more study validation from processed_study.cc. #1183
Conversation
| ); | ||
| } | ||
|
|
||
| // Validate total probability. | ||
| if (totalProbability !== 100) { |
There was a problem hiding this comment.
generally it's not neccessarily true, but probably we can limit ourself to 100 for simplicity
There was a problem hiding this comment.
We can assume totalProbability == 100 for Griffin, but not for Finch, so the code will be non-reusable.
Not sure that it's a real issue, because we don't validate Finch right now.
There was a problem hiding this comment.
We can assume
totalProbability == 100for Griffin
yes, that's what we did before and I assume we will continue doing. It's just easier to view this as 0-100 percent value.
| // Validate features. | ||
| if (experiment.feature_association !== undefined) { | ||
| if ( | ||
| experiment.feature_association.enable_feature !== undefined && |
There was a problem hiding this comment.
Can we use experiment?.feature_association to remove if (experiment.feature_association !== undefined)?
Also, !==undefined can't be get rid off if it's an object.
| experiment.feature_association.enable_feature !== undefined && | ||
| experiment.feature_association.enable_feature.length > 0 | ||
| ) { | ||
| for (const feature of experiment.feature_association.enable_feature) { |
There was a problem hiding this comment.
WDYT about making let features_to_check: string[] = [] and extending it.
Then just a one for-loop to check them all.
| // Valiate params. | ||
| const paramNames = new Set<string>(); | ||
| if (experiment.param.length > 0) { | ||
| for (const param of experiment.param) { |
There was a problem hiding this comment.
nit: for (const param of experiment.param || [])
goodov
force-pushed
the
validate-seed-more
branch
2 times, most recently
from
2320048
to
d94d251
Compare
goodov
force-pushed
the
validate-seed-more
branch
from
d94d251
to
6174eb6
Compare
Implement additional validation that exists in processed_study.cc.
Important ones:
Other was added just to have the full coverage (forcing_flag, google_web_experiment_id).