Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Enable New Playlist UI to Beta and Nightly [staging] #1149

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jul 30, 2024

Fixes #1148

Copy link
Contributor

github-actions bot commented Jul 30, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1149.
    Android: Set the command line to --variations-pr=1149 in debug menu, restart the browser.
    iOS: Set Variations PR to 1149 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1149@f702a04701b08f8681bc74d7b72f8e7746732c11
  • Uploaded: 2024-08-01T16:45:39.268Z
  • Serial Number: bc26d60f7af322543e38bc5c4215f8b5

@kjozwiak
Copy link
Member

kjozwiak commented Aug 1, 2024

The following basically ensures that the new Playlist UI/UX is being displayed/used on only Nightly & BETA. The feature will be verified in more detail once QA starts running through the feature.

Nightly verification(s)

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.70.41 Chromium: 127.0.6533.88 (Official Build) nightly (64-bit) 
--- | ---
Revision | 9303bae9fe07...
OS | iOS

Using the STR/Cases outlined via #1149 (comment), ensured that the new Playlist feature is being enabled on Nightly without any issues.

  • ensured that pull/1149@f702a04701b08f8681bc74d7b72f8e7746732c11 is being displayed via brave://version
  • verified that the new Playlist onboarding is being displayed/shown via Hamburger Menu -> Playlist
  • ensured that the new UI/UX is being displayed when viewing a video that has already been saved
Example Example Example Example Example
IMG_0441 IMG_0437 IMG_0438 IMG_0439 IMG_0440

BETA verification(s)

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.69.131 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
--- | ---
Revision | 7f9c5cb9840e...
OS | iOS

Using the STR/Cases outlined via #1149 (comment), ensured that the new Playlist feature is being enabled on Nightly without any issues.

  • ensured that pull/1149@f702a04701b08f8681bc74d7b72f8e7746732c11 is being displayed via brave://version
  • verified that the new Playlist onboarding is being displayed/shown via Hamburger Menu -> Playlist
  • ensured that the new UI/UX is being displayed when viewing a video that has already been saved
Example Example Example Example Example
IMG_0441 IMG_0442 IMG_0443 IMG_0444 IMG_0446

Release verification(s)

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.68.134 Chromium: 127.0.6533.88 (Official Build) stable (64-bit) 
--- | ---
Revision | 71f3c9cc80f9...
OS | iOS

Using the STR/Cases outlined via #1149 (comment), ensured that the new Playlist feature is being enabled on Nightly without any issues.

Example Example Example Example
IMG_0448 IMG_0449 IMG_0450 IMG_0451

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into master so we can uplift/merge #1150 into production.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 1, 2024
@kjozwiak kjozwiak removed this pull request from the merge queue due to a manual request Aug 1, 2024
@kjozwiak kjozwiak merged commit c4652a5 into main Aug 1, 2024
7 checks passed
@kjozwiak kjozwiak deleted the enable-playlist2.0-beta branch August 1, 2024 18:49
kjozwiak pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable iOS Playlist UI revamp to Beta and Nightly as a default.
2 participants