-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Enable New Playlist UI to Beta and Nightly [staging] #1149
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
The following basically ensures that the new
|
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
BETA
verification(s)
Verification PASSED on iPhone 11
running iOS 17.5.1
using the following build(s):
Brave | 1.69.131 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
--- | ---
Revision | 7f9c5cb9840e...
OS | iOS
Using the STR/Cases outlined via #1149 (comment), ensured that the new Playlist
feature is being enabled on Nightly
without any issues.
- ensured that
pull/1149@f702a04701b08f8681bc74d7b72f8e7746732c11
is being displayed viabrave://version
- verified that the new
Playlist
onboarding is being displayed/shown viaHamburger Menu
->Playlist
- ensured that the new UI/UX is being displayed when viewing a video that has already been saved
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Release
verification(s)
Verification PASSED on iPhone 11
running iOS 17.5.1
using the following build(s):
Brave | 1.68.134 Chromium: 127.0.6533.88 (Official Build) stable (64-bit)
--- | ---
Revision | 71f3c9cc80f9...
OS | iOS
Using the STR/Cases outlined via #1149 (comment), ensured that the new Playlist
feature is being enabled on Nightly
without any issues.
- ensured that
pull/1149@f702a04701b08f8681bc74d7b72f8e7746732c11
is being displayed viabrave://version
- ensured that the new
Playlist
UI/UX is NOT being applied toRelease
as per https://github.com/brave/brave-variations/pull/1149/files#diff-7ac2945ede68c73330363911678f6c9a2a6290b70e2dd170868295f65da7e872R3045
Example |
Example |
Example |
Example |
---|---|---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into master
so we can uplift/merge #1150 into production
.
Fixes #1148