Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BraveWalletAnkrBalances rollout #1146

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Disable BraveWalletAnkrBalances rollout #1146

merged 3 commits into from
Aug 1, 2024

Conversation

onyb
Copy link
Member

@onyb onyb commented Jul 30, 2024

Too many operational issues on production, so we have decided to disable rollout of Ankr balances feature until there's consistent evidence of better performance.

@onyb onyb self-assigned this Jul 30, 2024
@onyb onyb requested a review from a team as a code owner July 30, 2024 05:35
Copy link
Contributor

github-actions bot commented Jul 30, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1146.
    Android: Set the command line to --variations-pr=1146 in debug menu, restart the browser.
    iOS: Set Variations PR to 1146 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1146@6379c91e037d6b8fc639c5b1f0afe795926a7e29
  • Uploaded: 2024-08-01T18:56:05.518Z
  • Serial Number: 2d9948d4f6642736134133b2ba06c008

@srirambv
Copy link

srirambv commented Aug 1, 2024

Verification passed on

Brave 1.70.40 Chromium: 127.0.6533.88 (Official Build) nightly (64-bit)
Revision efaf75994a59fed0cf6318aa9b56e5293fbd676a
OS Linux
  • Verified on a clean profile BraveWalletAnkrBalancesEnabled is set to Enabled
  • Verified brave://flags/#brave-wallet-enable-ankr-balances is also set to Default (Enabled)
  • Verified relaunching the browser with --variations-pr=1146 arguments and waiting for a few seconds and restarting again sets BraveWalletAnkrBalancesEnabled to Disabled and brave://flags/#brave-wallet-enable-ankr-balances is also set to Default (Disabled)
1146.mp4

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Quick change re: disabling/setting BraveWalletAnkrBalancesEnabled to 0%.

@kjozwiak kjozwiak merged commit 4855312 into main Aug 1, 2024
7 checks passed
@kjozwiak kjozwiak deleted the disable-ankr branch August 1, 2024 20:05
@goodov
Copy link
Member

goodov commented Aug 2, 2024

@onyb this should be mirrored into production. Pls create one more PR and merge it.

I've created a production PR: #1146

goodov added a commit that referenced this pull request Aug 2, 2024
kjozwiak pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants