Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Removes rewards from the repo #540

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Removes rewards from the repo #540

merged 3 commits into from
Sep 19, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 18, 2019 •
edited by petemill
Loading

Changes

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR: Brave rewards ui brave-core#3463
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Sep 18, 2019
@NejcZdovc NejcZdovc mentioned this pull request Sep 18, 2019
Merged
32 tasks
petemill
petemill approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being so thorough in your cleanup! ♻️

@petemill petemill merged commit 8870019 into master Sep 19, 2019
@petemill petemill deleted the remove-rewards branch September 19, 2019 18:20
NejcZdovc pushed a commit that referenced this pull request Oct 8, 2019
@petemill @NejcZdovc
Removes rewards from the repo (#540)
6fa1239 
Removes rewards from the repo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petemill petemill petemill approved these changes

@ryanml ryanml Awaiting requested review from ryanml

@masparrow masparrow Awaiting requested review from masparrow

@cezaraugusto cezaraugusto Awaiting requested review from cezaraugusto

Assignees

@NejcZdovc NejcZdovc

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @petemill