Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Adding solid color uphold logo #538

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Adding solid color uphold logo #538

merged 1 commit into from
Sep 18, 2019
+10 −200

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 16, 2019

@ryanml ryanml self-assigned this Sep 16, 2019
@ryanml ryanml mentioned this pull request Sep 16, 2019
Merged
32 tasks
@ryanml ryanml requested a review from a team September 16, 2019 19:26
@ryanml ryanml added the rewards label Sep 16, 2019
emerick
emerick approved these changes Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NejcZdovc
NejcZdovc suggested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to center icon like we do for other icons

image

NejcZdovc
NejcZdovc previously requested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new logo is slimmer than the old one, so we will need to adjust curves as well. Sadly we can't just replace colors

masparrow
masparrow approved these changes Sep 17, 2019
View reviewed changes
Copy link

@masparrow masparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Sep 18, 2019

@jenn-rhim are you able to help out with this one? New SVG Logo provided was not optimized for a 0 0 32 32 viewbox, which is our icon standard. New Uphold logo has slimmer lines so the old can not just be tweaked color wise. New one should be able to replace the old one without any styling updates, thanks!

@jenn-rhim
Copy link
Contributor

@ryanml sending it offline.

@ryanml
Copy link
Contributor Author

ryanml commented Sep 18, 2019

New logo provided by @jenn-rhim is in line with new design and complies with our icon standards: https://brave-ui-grte4ykm4.now.sh

@ryanml ryanml merged commit 2716232 into master Sep 18, 2019
@ryanml ryanml deleted the uphold-log-update branch September 18, 2019 20:09
ryanml added a commit that referenced this pull request Sep 19, 2019
@ryanml
Merge pull request #538 from brave/uphold-log-update
6f448e2 
Adding solid color uphold logo
ryanml added a commit that referenced this pull request Sep 19, 2019
@ryanml
Merge pull request #538 from brave/uphold-log-update
66df3bd 
Adding solid color uphold logo
ryanml added a commit that referenced this pull request Sep 24, 2019
@ryanml
Merge pull request #538 from brave/uphold-log-update
321a99b 
Adding solid color uphold logo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emerick emerick emerick approved these changes

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@masparrow masparrow masparrow approved these changes

Assignees

@ryanml ryanml

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanml @jenn-rhim @emerick @NejcZdovc @masparrow