-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
For reviewers: Reasoning around implementing the show/hide via HOC logic is that we will be extending our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@@ -66,3 +68,5 @@ export class Clock extends React.PureComponent<{}, ClockState> { | |||
) | |||
} | |||
} | |||
|
|||
export const ClockWidget = createWidget(Clock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit to say that this (and some other things in this PR) breaks backwards compatibility with the brave-core consumer, so any gap between this PR being merged with brave-ui's sha that brave-core is using, and the sister brave-core PR being merged, will result in broken builds. But the remedy for now is just to make sure they are merged very quickly together :-)
Spec: brave/brave-browser#4510
Changes
Test plan
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?
Add setting options to toggle NTP widgets brave-core#2762