Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Adds token text to grant final screen #499

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Adds token text to grant final screen #499

merged 1 commit into from
Jun 12, 2019

Conversation

NejcZdovc
Copy link
Contributor

Changes

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Jun 12, 2019
@NejcZdovc NejcZdovc force-pushed the grant-text branch 2 times, most recently from 14c0eb5 to 86fc4b0 Compare June 12, 2019 10:11
@NejcZdovc NejcZdovc requested a review from tmancey June 12, 2019 10:32
tmancey
tmancey suggested changes Jun 12, 2019
View reviewed changes
stories/features/rewards/concepts.tsx Outdated
hint: ''
hint: '',
finishTitle: 'It\'s your lucky day!',
finishText: 'Your token grant is on its way',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a full-stop to be consistent with UGP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@NejcZdovc NejcZdovc mentioned this pull request Jun 12, 2019
Merged
29 tasks
@NejcZdovc NejcZdovc merged commit 624be47 into master Jun 12, 2019
@NejcZdovc NejcZdovc deleted the grant-text branch June 12, 2019 13:08
ryanml added a commit that referenced this pull request Jun 28, 2019
@ryanml
Reverting PR #499
34aa6c9
@ryanml ryanml mentioned this pull request Jun 28, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmancey tmancey tmancey approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @tmancey