Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Using overflow-y: auto for unverified notice #439

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Using overflow-y: auto for unverified notice #439

merged 1 commit into from
Mar 31, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 31, 2019

Related: brave/brave-browser#3930

You should not see the scrollbar in storybook on MacOS now if you have your preferences set to always show scroll bars.

Changes

Test plan

Link / storybook path to visual changes

https://brave-ui-n12kj8qp7.now.sh

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml ryanml merged commit 44513d1 into master Mar 31, 2019
@ryanml ryanml deleted the fix-3930 branch March 31, 2019 05:44
ryanml added a commit that referenced this pull request Apr 1, 2019
Using overflow-y: auto for unverified notice
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants