Merge pull request #437 from brave/console-fix

Fixing panel console error
brave · Mar 27, 2019 · aebb6e7 · aebb6e7
2 parents d67680b + f463af5
commit aebb6e7
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 8 deletions.
diff --git a/src/features/rewards/rewardsButton/__snapshots__/spec.tsx.snap b/src/features/rewards/rewardsButton/__snapshots__/spec.tsx.snap
@@ -35,7 +35,6 @@ exports[`TipButton tests basic tests matches the snapshot 1`] = `
 >
   <span
     className="c1"
-    icon={false}
   />
 </button>
 `;
diff --git a/src/features/rewards/rewardsButton/index.tsx b/src/features/rewards/rewardsButton/index.tsx
@@ -32,7 +32,7 @@ export default class RewardsButton extends React.PureComponent<Props, {}> {
         onClick={onClick}
         data-test-id={testId}
       >
-        <StyledButtonText icon={!!icon}>
+        <StyledButtonText hasIcon={!!icon}>
           {text}
           {
             icon

diff --git a/src/features/rewards/rewardsButton/style.ts b/src/features/rewards/rewardsButton/style.ts
@@ -8,7 +8,7 @@ import styled, { css } from 'styled-components'
 
 interface StyleProps {
   type?: Type
-  icon?: boolean
+  hasIcon?: boolean
   disabled?: boolean
 }
 
@@ -78,7 +78,7 @@ export const StyledButtonText = styled<StyleProps, 'span'>('span')`
   font-weight: 600;
   text-transform: uppercase;
   letter-spacing: 0.39px;
-  margin: ${p => p.icon ? '-3px auto 0px' : '0 auto'};
+  margin: ${p => p.hasIcon ? '-3px auto 0px' : '0 auto'};
 `
 
 export const StyledIcon = styled<{}, 'div'>('div')`

diff --git a/src/features/rewards/walletPanel/__snapshots__/spec.tsx.snap b/src/features/rewards/walletPanel/__snapshots__/spec.tsx.snap
@@ -180,7 +180,6 @@ exports[`WalletPanel tests basic tests matches the snapshot 1`] = `
       >
         <span
           className="c11"
-          icon={false}
         >
           MISSING: donateNow
         </span>

diff --git a/src/features/rewards/walletPanelDisabled/__snapshots__/spec.tsx.snap b/src/features/rewards/walletPanelDisabled/__snapshots__/spec.tsx.snap
@@ -211,7 +211,6 @@ exports[`DisabledPanel tests basic tests matches the snapshot 1`] = `
     >
       <span
         className="c8"
-        icon={true}
       >
         MISSING: enableRewards
         <div

diff --git a/src/features/rewards/welcomePage/__snapshots__/spec.tsx.snap b/src/features/rewards/welcomePage/__snapshots__/spec.tsx.snap
@@ -509,7 +509,6 @@ exports[`WelcomePage tests basic tests matches the snapshot 1`] = `
             >
               <span
                 className="c18"
-                icon={false}
               >
                 MISSING: braveRewardsOptInText
               </span>
@@ -735,7 +734,6 @@ exports[`WelcomePage tests basic tests matches the snapshot 1`] = `
               >
                 <span
                   className="c18"
-                  icon={false}
                 >
                   MISSING: readyToTakePartOptInText
                 </span>
-Original file line number
+Diff line change
@@ Expand Up @@
           >
             <span
               className="c11"
-              icon={false}
             >
               MISSING: donateNow
             </span>
@@ Expand Down @@