This repository has been archived by the owner on May 10, 2024. It is now read-only.
[ads] Unify iOS kBraveNTPBrandedWallpaper #8702
Merged
+9
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #8701
Requires brave/brave-core#21751
Submitter Checklist:
NSLocalizableString()
Test Plan:
Active Variations:
list contains the enabled studies for iOS.Active Variations:
then terminate and start browser. Make sure thatActive Variations:
list contains the enabled studies for iOS.BraveNTPBrandedWallpaper
/initial_count_to_branded_wallpaper
Griffin feature paramBraveNTPBrandedWallpaper
/count_to_branded_wallpaper
Griffin feature paramWe should also test the default values if the Griffin feature does not exist. Default value is 2 for
BraveNTPBrandedWallpaper
/initial_count_to_branded_wallpaper
and 3 forBraveNTPBrandedWallpaper
/count_to_branded_wallpaper
.And that the position is persisted across browser restarts.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement