Fix #7827: Sign In With Ethereum

[StephenHeaps]

Summary of Changes

• Refactored existing SignatureRequestView which was used for all SignMessageRequest types into 3 views:

1. SignInWithEthereumView which is used for displaying Sign In With Ethereum / Brave Wallet requests
2. SignMessageRequestView which is the existing SignatureRequestView, including pilcrow formatting
3. SignMessageRequestContainerView which is used to switch between the requests when there are multiple. This view also stores the pilcrow formatting & unknown unicode character states so they are preserved when switching between requests.

This pull request fixes #7827

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()
• New or updated UI has been tested across:
  • Light & dark mode
  • Different size classes (iPhone, landscape, iPad)
  • Different dynamic type sizes

Test Plan:

Normal flow

No resources

1. Setup wallet and navigate to https://login.xyz/
2. Click SIGN-IN WITH ETHEREUM button.
3. Grant connect permission.
4. We should be able to see SIWE UI.
5. Click approve to sign in.

With resources

1. Setup wallet and navigate to https://metamask.github.io/test-dapp/
2. Click SIGN-IN WITH ETHEREUM w/resources button.
3. Grant connect permission.
4. We should be able to see SIWE UI(Check if resources is displayed properly)
5. Click approve to sign in.

Errors

3. Navigate to https://bbondy.github.io/eth-manual-tests/request.html
4. Make sure wallet is on ETH mainnet
5. Connect wallet to it
6. Paste following message to the text area next to SIWE and click it

Wrong format will fallback to eip-191 sign UI and no error

this is for example wrong statement format

https://bbondy.github.io wants you to sign in with your Ethereum account:
TYPE YOUR ACCOUNT ADDRESS HERE
URI: https://bbondy.github.io/eth-manual-tests
Version: 1
Chain ID: 1
Nonce: 32891756
Issued At: 2021-09-30T16:25:24Z

Domain mismatch

example.com wants you to sign in with your Ethereum account:
TYPE YOUR ACCOUNT ADDRESS HERE


URI: https://bbondy.github.io/eth-manual-tests
Version: 1
Chain ID: 1
Nonce: 32891756
Issued At: 2021-09-30T16:25:24Z

https://bbondy.github.io wants you to sign in with your Ethereum account:
TYPE YOUR ACCOUNT ADDRESS HERE


URI: https://example.com/eth-manual-tests
Version: 1
Chain ID: 1
Nonce: 32891756
Issued At: 2021-09-30T16:25:24Z

Account mismatch

https://bbondy.github.io wants you to sign in with your Ethereum account:
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2


URI: https://bbondy.github.io/eth-manual-tests
Version: 1
Chain ID: 1
Nonce: 32891756
Issued At: 2021-09-30T16:25:24Z

Network mismatch

https://bbondy.github.io wants you to sign in with your Ethereum account:
TYPE YOUR ACCOUNT ADDRESS HERE


URI: https://bbondy.github.io/eth-manual-tests
Version: 1
Chain ID: 137
Nonce: 32891756
Issued At: 2021-09-30T16:25:24Z

Regression Test

Verify existing pilcrow & unknown unicode formatting from #6300. Logic is unchanged but views were refactored slightly. Connect to Metamask test dapp and use Safari debugger to submit:

Unknown characters & consecutive new lines

window.ethereum.request({"method":"personal_sign","params":["YOURADDRESSHERE", "Sign into \u202E EVIL\n\n\nMain Message\nEvil payload is below \n\n\n\n\n\n\n\n\n\n\n\nMy Evil payload"],"id":1})

Consecutive new lines & contains pilcrow in message; verify pilcrow in message not replaced

window.ethereum.request({"method":"personal_sign","params":["YOURADDRESSHERE", "Message with pilcrow - \u{00B6}\n\n\n\n\n\n\n\n\n\n\n\n\nMessage"],"id":1})

_	(pilcrow shows as \u{00B6} in encoded message as it's outside unicode range)

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue and pull request is assigned to a milestone (should happen at merge time).

[github-actions]

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "login" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

[kdenhartog]

One nit, but no blockers. LGTM for security

[StephenHeaps]

@kylehickinson all comments should be addressed in f2266bf

[nuo-xu]

everything looks great. however, i can't verify the regression test for existing pilcrow & unknown unicode formatting. window.ethereum.request always crashes on reject(JSON.parse(errorJSONStringSliced)). maybe we can go through it together when we regroup today. [Resolved]
one minor thing, I found that in SIWE detail, Address value will be wrapped with a - in iOS 17. But ofc, the copy value is correct. Just want to point out.

[StephenHeaps]

one minor thing, I found that in SIWE detail, Address value will be wrapped with a - in iOS 17. But ofc, the copy value is correct. Just want to point out.

I think the wrapping works better than truncation here since we have the space, and user can tap & hold to copy the full address.