Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove dislike ad button #8212

Closed
wants to merge 1 commit into from
Closed

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 9, 2023

Summary of Changes

This pull request fixes #8211

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Confirm user cannot dislike a notification ad by swiping

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@tmancey tmancey self-assigned this Oct 9, 2023
@tmancey tmancey requested a review from a team as a code owner October 9, 2023 16:02
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is going to be removed, we should also remove all the logic around the dislike button (RewardsNotification.Action.disliked for instance, the swipe gesture on the ads, etc.)

@kylehickinson
Copy link
Collaborator

Closing as I will be taking this over

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dislike ad button
2 participants