Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8078: Update browser colors #8079

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #8078
This pull request fixes #6839

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Test browser chrome UI across light, dark and private mode

Screenshots:

Examples:

Light Dark Private
Simulator Screenshot - iPhone 15 Pro - 2023-09-18 at 11 22 26 Simulator Screenshot - iPhone 15 Pro - 2023-09-18 at 11 22 29 Simulator Screenshot - iPhone 15 Pro - 2023-09-18 at 11 22 35

But there are many more changes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner September 18, 2023 15:23
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was much more work than I expected.
Looks great and good job

@kylehickinson kylehickinson added this to the 1.59 milestone Sep 21, 2023
@kylehickinson kylehickinson merged commit cb5e8d9 into development Sep 21, 2023
7 checks passed
@kylehickinson kylehickinson deleted the browser-color-update branch September 21, 2023 20:16
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Browser Colors Browser chrome for dark theme needs to be darker
2 participants