Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8019: Fix issues with farbling plugins on iOS 17 #8030

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Fix #8019: Fix issues with farbling plugins on iOS 17 #8030

merged 5 commits into from
Sep 7, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Sep 5, 2023

Summary of Changes

This pull request fixes #8019

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

STR in issue

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner September 5, 2023 20:44
@iccub iccub requested a review from Brandon-T September 6, 2023 15:20
@iccub iccub added this to the 1.57.1 milestone Sep 6, 2023
@iccub iccub requested a review from Brandon-T September 7, 2023 14:44
@cuba cuba merged commit 9f8ad81 into development Sep 7, 2023
7 checks passed
@cuba cuba deleted the js/8019-add-try-catch-to-farbling branch September 7, 2023 15:56
iccub pushed a commit that referenced this pull request Sep 11, 2023
@cuba @iccub
Fix #8019: Fix issues with farbling plugins on iOS 17 (#8030)
af8ca64 
* Add try catch to farbling

* Fix issue with plugins farbling for iOS 17

* Remove unwanted changer

* Fix for review

* Move comments below the respective values
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@cuba
Fix brave/brave-ios#8019: Fix issues with farbling plugins on iOS 17 (b…
087da43 
…rave/brave-ios#8030)

* Add try catch to farbling

* Fix issue with plugins farbling for iOS 17

* Remove unwanted changer

* Fix for review

* Move comments below the respective values
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Brandon-T Brandon-T Brandon-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.57.1
3 participants
@cuba @Brandon-T @iccub