Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7710: isSpam data model update for WalletUserAsset #8008

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Aug 31, 2023

Summary of Changes

isSpam is a new property from TokenInfo from 1.58.x. We will need to update our WalletUserAsset to have the same attribute with default value false and it will be used for the new NFT Spam Management issue #8006

This pull request fixes #7710

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Install a older version of Brave
  2. Set up wallet and edit some visible assets
  3. Upgrade to 1.58
  4. Portfolio/NFT should display the same tokens.
  5. Edit visible assets should still behave the same.
    No crash should occur.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.58 milestone Aug 31, 2023
@nuo-xu nuo-xu requested a review from StephenHeaps August 31, 2023 20:40
@nuo-xu nuo-xu requested a review from a team as a code owner August 31, 2023 20:40
@nuo-xu nuo-xu self-assigned this Aug 31, 2023
@soner-yuksel soner-yuksel merged commit a6b0087 into development Sep 1, 2023
@soner-yuksel soner-yuksel deleted the wallet/isSpam-migration branch September 1, 2023 16:49
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: Update WalletUserAsset model to include isSpam
3 participants