Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7993: Test networks are not displayed in BSS network dropdown #7994

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Aug 29, 2023

Summary of Changes

This pull request fixes #7993

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Please refer to the issue

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.57 milestone Aug 29, 2023
@nuo-xu nuo-xu requested a review from StephenHeaps August 29, 2023 21:31
@nuo-xu nuo-xu requested a review from a team as a code owner August 29, 2023 21:31
@nuo-xu nuo-xu self-assigned this Aug 29, 2023
@nuo-xu nuo-xu merged commit 403c08e into development Aug 29, 2023
@nuo-xu nuo-xu deleted the bugfix/all-networks branch August 29, 2023 22:08
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: Network dropdown in BSS does not include testnets if test networks is turned on in Settings
2 participants