Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3939: Add Screen Time support. #7983

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix #3939: Add Screen Time support. #7983

merged 3 commits into from
Sep 18, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Aug 29, 2023

Summary of Changes

Old PR by our contributor here #7639

This pull request fixes #3939
Security review https://github.com/brave/reviews/issues/1383

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Verify that when you stay on a website for a bit it is tracked in Screen Time section in iOS settings.
  2. Verify that after setting a time limit for a website, after you reach the limit you are not able to access it anymore.
  3. Verify that websites are not tracked in private browsing mode

Disabled tests:

  1. Turn off the feature - verify that websites are not tracked again
  2. Turn off the feature - verify that the website where you reached the time limit can be accessed

Screenshots:

All the in-website UI is Apple controlled.
Zrzut ekranu 2023-08-29 o 13 40 11

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from Brandon-T August 29, 2023 16:51
@iccub iccub added this to the 1.58 milestone Sep 18, 2023
@iccub iccub merged commit 4ee24f3 into development Sep 18, 2023
@iccub iccub deleted the screentime branch September 18, 2023 13:13
@Uni-verse Uni-verse mentioned this pull request Sep 27, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement screentime
5 participants