This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7942, #7943, #7964: Onboarding UI issues #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set of recovery phrases. Fix cursor problem when user inputs space
…eading and trailing white spaces for user input phrase.
nuo-xu
changed the title
StephenHeaps
approved these changes
Aug 25, 2023
nuo-xu
added a commit
that referenced
this pull request
Aug 25, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
… Onboarding UI issues (brave/brave-ios#7960)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #7942 brave/brave-browser#36775 #7964
Submitter Checklist:
NSLocalizableString()Test Plan:
Please refer to the issues
Screenshots:
#7942
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-24.at.21.11.55.mp4
brave/brave-browser#36775
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-24.at.21.34.02.mp4
#7964
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-25.at.13.50.53.mp4
Reviewer Checklist:
QA/(Yes|No)bug/enhancement