Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7876: Replace Rewards ads usage P3A question #7935

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

kylehickinson
Copy link
Collaborator

This removes the Brave.Rewards.AdsEnabledDuration question and answers the new Brave.Rewards.AdTypesEnabled question

Summary of Changes

This pull request fixes #7876

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Fresh Installs should no longer report Brave.Rewards.AdsEnabledDuration
  • Verify that Brave.Rewards.AdTypesEnabled sends correct answers for ads/NTP-SI settings

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

This removes the `Brave.Rewards.AdsEnabledDuration` question and answers the new `Brave.Rewards.AdTypesEnabled` question
@kylehickinson kylehickinson added this to the 1.58 milestone Aug 23, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner August 23, 2023 20:22
@kylehickinson kylehickinson enabled auto-merge (squash) August 23, 2023 20:23
@kylehickinson kylehickinson merged commit 95556f5 into development Aug 23, 2023
@kylehickinson kylehickinson deleted the ads-p3a-switch branch August 23, 2023 21:15
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…ve/brave-ios#7935)

This removes the `Brave.Rewards.AdsEnabledDuration` question and answers the new `Brave.Rewards.AdTypesEnabled` question
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "ads enabled duration" P3A metric with "ad types enabled"
2 participants