This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7897: Clearing Out Data From Recently Closed Tabs #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/Brave/Frontend/Browser/Tabs/RecentlyClosedTabs/RecentlyClosedTabsView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for the contribution, this is a nice simple way to solve this problem. Please make this small change mentioned #7919 (comment) so I can approve and we can merge.
soner-yuksel
approved these changes
Aug 23, 2023
JonKaleidoscope
force-pushed
the
#7897_Fix_Clearing_Recently_Closed_Tabs
branch
from
ad39f55 to
ee3d8fb
Compare
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #7897. When clearing recently closed tabs, data was being persisted.
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)bug/enhancement