Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7873: Skip old reddit redirect when loading new reddit media page #7895

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

kylehickinson
Copy link
Collaborator

i.redd.it/{id} now redirects to a new media viewer page instead of viewing the content directly, and that media page is located at reddit.com/media?url={iredditurl}. If we attempt to redirect this URL to old.reddit.com, it will be treated as a post lookup instead of the media viewer, and end up on a random /r/funny post from years ago

Summary of Changes

This pull request fixes #7873

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

`i.redd.it/{id}` now redirects to a new media viewer page instead of viewing the content directly, and that media page is located at `reddit.com/media?url={iredditurl}`. If we attempt to redirect this URL to `old.reddit.com`, it will be treated as a post lookup instead of the media viewer, and end up on a random /r/funny post from years ago
@kylehickinson kylehickinson requested a review from a team as a code owner August 17, 2023 20:07
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@kylehickinson kylehickinson added this to the 1.57 milestone Aug 17, 2023
@kylehickinson kylehickinson merged commit 12fe7ab into development Aug 17, 2023
@kylehickinson kylehickinson deleted the reddit-redirect-fix branch August 17, 2023 22:56
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed URLs for i.redd.it posts when using the reddit.com -> old.reddit.com website redirect
3 participants