Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Remove duplicated localized strings #7888

Merged
merged 1 commit into from
Aug 17, 2023
Merged

No Bug: Remove duplicated localized strings #7888

merged 1 commit into from
Aug 17, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Aug 17, 2023 •
edited
Loading

Summary of Changes

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from a team as a code owner August 17, 2023 14:46
@iccub iccub added the QA/No label Aug 17, 2023
@iccub iccub added this to the 1.57 milestone Aug 17, 2023
@iccub iccub enabled auto-merge (squash) August 17, 2023 14:50
@iccub iccub merged commit d9113d8 into development Aug 17, 2023
@iccub iccub deleted the nobug/dupe_localized_strings branch August 17, 2023 15:10
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@iccub
No Bug: Remove duplicated localized strings (brave/brave-ios#7888)
9872c1d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees
No one assigned
Labels
QA/No
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.
2 participants
@iccub @StephenHeaps