Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7642: Move reload long press action to UIContext menu action. #7841

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix #7642: Move reload long press action to UIContext menu action. #7841

merged 4 commits into from
Aug 10, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Aug 8, 2023 •
edited
Loading

Summary of Changes

I also cleaned up other long press actions

This pull request fixes #7642

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from a team as a code owner August 8, 2023 09:43
@kylehickinson
Copy link
Collaborator

Why not move the actions into the regular url bar long press context menu? Wouldn't that be simpler?

soner-yuksel
soner-yuksel reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution, just couple of nits

@iccub iccub requested a review from Brandon-T August 9, 2023 15:41
@iccub
Copy link
Contributor Author

iccub commented Aug 9, 2023

Zrzut ekranu 2023-08-8 o 18 56 00

@iccub iccub added this to the 1.57 milestone Aug 9, 2023
@iccub iccub merged commit 81876bd into development Aug 10, 2023
@iccub iccub deleted the bugfix/7642 branch August 10, 2023 15:45
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@iccub
Fix brave/brave-ios#7642: Move reload long press action to UIContext …
bf2ce97 
…menu action. (brave/brave-ios#7841)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson left review comments

@soner-yuksel soner-yuksel soner-yuksel approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.

URL Bar Context Menu is interfering with URL Bar Custom Buttons Long Press Action
4 participants
@iccub @kylehickinson @Brandon-T @soner-yuksel