Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7823: Select Account not always showing checkmark #7824

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Bug in comparison to determine if an account is selected. Object instance was being compared instead of the account's id.

This pull request fixes #7823

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open Wallet Panel and tap the blockie for the selected account
  2. In the Select Account modal, verify the checkmark is shown as expected.
  3. Select a different account, then re-open Select Account and verify the checkmark is shown as expected.
  4. Add a new account, verify checkmark is shown as expected

Screenshots:

account.select.checkmark.fixed.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 3, 2023
@StephenHeaps StephenHeaps requested a review from nuo-xu August 3, 2023 14:08
@StephenHeaps StephenHeaps requested a review from a team as a code owner August 3, 2023 14:08
@StephenHeaps StephenHeaps self-assigned this Aug 3, 2023
@StephenHeaps StephenHeaps merged commit 0c6a127 into development Aug 3, 2023
@StephenHeaps StephenHeaps deleted the wallet/select-account-checkmark branch August 3, 2023 15:39
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkmark does not show beside selected account
2 participants