Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7819: Resetting Speech Recognizer properly after valid search conditions #7820

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 2, 2023

Summary of Changes

This pull request fixes #7819
This pull request fixes #7686

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

sanity check for multiple searches

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.56 milestone Aug 2, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 2, 2023 19:49
@soner-yuksel soner-yuksel self-assigned this Aug 2, 2023
@iccub iccub enabled auto-merge (squash) August 2, 2023 20:55
@iccub iccub merged commit 1127d32 into development Aug 2, 2023
@iccub iccub deleted the fix/voice-search-reset branch August 2, 2023 20:58
@soner-yuksel soner-yuksel changed the title Ref #7686: Resetting Speech Recognizer properly after valid search conditions Fix #7819: Resetting Speech Recognizer properly after valid search conditions Aug 2, 2023
iccub pushed a commit that referenced this pull request Aug 2, 2023
…nditions (#7820)

Resetting Speech Recognizer properly after valid search conditions
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…valid search conditions (brave/brave-ios#7820)

Resetting Speech Recognizer properly after valid search conditions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice search does not reset for consecutive searches Voice search not detecting sound
2 participants