Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No bug: Wallet unit test fixup #7756

Merged
merged 2 commits into from
Jul 21, 2023
Merged

No bug: Wallet unit test fixup #7756

merged 2 commits into from
Jul 21, 2023

Conversation

StephenHeaps
Copy link
Contributor

@StephenHeaps StephenHeaps commented Jul 19, 2023

Summary of Changes

  • Resolve AccountActivityStoreTests.testUpdateEthereumAccount() flakey test
  • Disabled:
    • TransactionConfirmationStoreTests.testPrepareERC20Approve()
    • TransactionConfirmationStoreTests.testPrepareTransactionNotOnSelectedNetwork()
  • Updated disabled SendTokenStoreTests tests. Reduced from 11 disabled tests to 6.
  • Opened Resolve Flakey Wallet Tests #7757 to resolve the disabled tests.

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. In the Brave.xctestplan, disable each of the disabled tests in our Fastfile
  2. In Xcode, open Test navigator panel
  3. Right-click on BraveWalletTests and select Run "BraveWalletTests" Repeatedly...
Screenshot 2023-07-19 at 5 05 17 PM
  1. Change Stop After to maximum repetitions and set Maximum Repetitions to >100 (100 wasn't catching them all, I used 1000 but less likely suffices).
Screenshot 2023-07-19 at 5 05 25 PM
  1. Click Run
  2. Make sure no other tests are failing.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps requested a review from nuo-xu July 19, 2023 21:23
@StephenHeaps StephenHeaps self-assigned this Jul 19, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner July 19, 2023 21:23
@StephenHeaps StephenHeaps added this to the 1.57 milestone Jul 20, 2023
@StephenHeaps StephenHeaps merged commit bd53681 into development Jul 21, 2023
@StephenHeaps StephenHeaps deleted the wallet/unit-tests branch July 21, 2023 14:31
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
* Resolve AccountActivityStoreTests.testUpdateEthereumAccount()

* Update disabled wallet tests for CI.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants