This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AccountActivityStoreTests.testUpdateEthereumAccount()
flakey testTransactionConfirmationStoreTests.testPrepareERC20Approve()
TransactionConfirmationStoreTests.testPrepareTransactionNotOnSelectedNetwork()
SendTokenStoreTests
tests. Reduced from 11 disabled tests to 6.This pull request fixes #
Submitter Checklist:
NSLocalizableString()
Test Plan:
Brave.xctestplan
, disable each of the disabled tests in ourFastfile
BraveWalletTests
and selectRun "BraveWalletTests" Repeatedly...
Stop After
to maximum repetitions and setMaximum Repetitions
to >100 (100 wasn't catching them all, I used 1000 but less likely suffices).Run
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement