Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #7728: Bump BraveCore to 1.57.13 #7740

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Ref #7728: Bump BraveCore to 1.57.13 #7740

merged 1 commit into from
Jul 17, 2023

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jul 17, 2023 •
edited
Loading

Summary of Changes

This includes a fix for #7728

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.57 milestone Jul 17, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner July 17, 2023 14:34
@kylehickinson kylehickinson enabled auto-merge (squash) July 17, 2023 14:36
@kylehickinson kylehickinson changed the title Ref #7738: Bump BraveCore to 1.57.13 Ref #7728: Bump BraveCore to 1.57.13 Jul 17, 2023
@kylehickinson kylehickinson disabled auto-merge July 17, 2023 14:36
@kylehickinson kylehickinson enabled auto-merge (squash) July 17, 2023 14:36
@kylehickinson kylehickinson merged commit e532093 into development Jul 17, 2023
@kylehickinson kylehickinson deleted the brave-core-dev-bump branch July 17, 2023 15:02
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Ref brave/brave-ios#7728: Bump BraveCore to 1.57.13 (brave/brave-ios#…
ba26101 
…7740)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehickinson @StephenHeaps