Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7686: Voice search not detecting sound #7727

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jul 12, 2023

Checking availability of speech recognizer and device recognizer in order to display voice search icon

Summary of Changes

This pull request fixes #7686

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Once on new tab, select the microphone icon in the URL bar
  • Enable mic permissions for Brave
  • Once the voice search modal opens, search query with your voice

And if the region of the user is not allowing voice search the button should be totally hidden

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.56 milestone Jul 12, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner July 12, 2023 21:02
@soner-yuksel soner-yuksel self-assigned this Jul 12, 2023
@soner-yuksel soner-yuksel merged commit 2b5091e into development Jul 13, 2023
@soner-yuksel soner-yuksel deleted the fix/voice-search-detection branch July 13, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice search not detecting sound
2 participants