Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7645: Move TabsBarViewController to use Drag and Drop delegates. #7646

Closed
wants to merge 1 commit into from

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jun 27, 2023

Summary of Changes

This pull request fixes #7645

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from Brandon-T June 27, 2023 13:08
@iccub iccub requested a review from a team as a code owner June 27, 2023 13:08
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jun 27, 2023
@iccub iccub closed this Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs bar reorder crash
2 participants