Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix # 7605: Camera view is rotated to 90 degrees in "Scan QR Code" UI when a device in Landscape Mode #7633

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jun 22, 2023

Adding viewWillTransition change for orientation in preview video layer orientation change

Summary of Changes

This pull request fixes #7605

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Launch Brave
  2. URL search bar > Remove URL
  3. Tap QR code thumbnail
  4. When Scan QR Code UI is opened rotate the device to Landscape Mode > Observe

Screenshots:

RPReplay_Final1687457608.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner June 22, 2023 18:15
@soner-yuksel soner-yuksel self-assigned this Jun 22, 2023
@iccub iccub added this to the 1.53 milestone Jun 22, 2023
@soner-yuksel soner-yuksel merged commit 44c8749 into development Jun 23, 2023
@soner-yuksel soner-yuksel deleted the fix/camera-scan-qrcode branch June 23, 2023 14:57
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera view is rotated to 90 degrees in "Scan QR Code" UI when a device in Landscape Mode
2 participants