Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7615: Don't leak status bar color while in overlay mode. #7616

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jun 19, 2023

Summary of Changes

This pull request fixes #7615

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from kylehickinson June 19, 2023 16:42
@iccub iccub requested a review from a team as a code owner June 19, 2023 16:42
@iccub iccub added this to the 1.53 milestone Jun 23, 2023
@iccub iccub merged commit 2e0cfab into development Jun 26, 2023
@iccub iccub deleted the bugfix/7615 branch June 26, 2023 14:59
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colored status bar leaks in overlay mode
3 participants