Fix bug where New Tab Page ad viewed events fail on iOS - 1.52.x #7568

tmancey · 2023-06-05T18:04:42Z

Summary of Changes

This pull request fixes #7566

Unit Tests are updated to cover new or changed functionality
User-facing strings use NSLocalizableString()
New or updated UI has been tested across:
- Light & dark mode
- Different size classes (iPhone, landscape, iPad)
- Different dynamic type sizes

Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
Necessary security reviews have taken place.
Adequate unit test coverage exists to prevent regressions.
Adequate test plan exists for QA to validate (if applicable).
Issue and pull request is assigned to a milestone (should happen at merge time).

tmancey · 2023-06-05T18:15:05Z

Closing as raised #7569

tmancey added this to the 1.52 milestone Jun 5, 2023

tmancey self-assigned this Jun 5, 2023

tmancey requested a review from a team as a code owner June 5, 2023 18:04

Fix bug where New Tab Page ad viewed events fail on iOS

95b4539

tmancey force-pushed the 7566-1.52.x branch from ae40867 to 95b4539 Compare June 5, 2023 18:06

tmancey closed this Jun 5, 2023

tmancey deleted the 7566-1.52.x branch June 5, 2023 18:15

kylehickinson removed this from the 1.52 milestone Jun 5, 2023