Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7233: Wallet Tx Activity Supports multiple networks #7441

Merged
merged 6 commits into from
May 15, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented May 11, 2023

Summary of Changes

Currently, all the screens that display transaction information is restricted by the default network from the current user selected account's coin type. Core now removes this restriction, so front-end is now able to fetch tx for all networks.

This pull request fixes #7233 #7385

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open Brave browser and login to Brave Wallet
  2. make some transaction using the same coin type but in different networks. (For example: Using a solana account to make some tx on Solana Mainnet and Solana Devnet. Using a eth account to make some tx on Eth mainnet and Goerli)
  3. Confirm or reject those tx
  4. Go to Activity tab
  5. Observe that all non-rejected for all accounts in all networks will be displayed
  6. Go to each account screen
  7. Observe that all tx made by this account in all networks will be displayed
  8. Go to activity history from the wallet panel
  9. Observe that all tx made by this account in all networks will be displayed
  10. Click the global BSS button and choose a different network.
  11. Repeat from step 4
  12. Step 5, 7 and 9 should also be expected.

Screenshots:

Simulator.Screen.Recording.-.iPhone.14.-.2023-05-11.at.10.56.55.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.52 milestone May 11, 2023
@nuo-xu nuo-xu requested a review from StephenHeaps May 11, 2023 14:57
@nuo-xu nuo-xu self-assigned this May 11, 2023
@nuo-xu nuo-xu requested a review from a team as a code owner May 11, 2023 14:57
@nuo-xu nuo-xu force-pushed the wallet/activiy-multi-networks branch from 21a4d5c to 036ba67 Compare May 15, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show transactions from all networks on activity tab
2 participants