Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7326: Add unit tests for update in asset detail store #7351

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Fix #7326: Add unit tests for update in asset detail store #7351

merged 3 commits into from
Apr 27, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Apr 27, 2023

Summary of Changes

Add two unit tests to test update function in asset detail store. One for BlockchainToken and the other for CoinMarket.

This pull request fixes #7326

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.51 milestone Apr 27, 2023
@nuo-xu nuo-xu requested a review from StephenHeaps April 27, 2023 15:36
@nuo-xu nuo-xu requested a review from a team as a code owner April 27, 2023 15:36
@nuo-xu nuo-xu self-assigned this Apr 27, 2023
StephenHeaps
StephenHeaps approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sources/BraveWallet/Preview Content/MockContent.swift Outdated Show resolved Hide resolved
Tests/BraveWalletTests/AssetDetailStoreTests.swift Show resolved Hide resolved
Tests/BraveWalletTests/AssetDetailStoreTests.swift Show resolved Hide resolved
@nuo-xu nuo-xu force-pushed the wallet/asset-store-unit-tests branch from 9594dbc to e5d699b Compare April 27, 2023 19:33
@nuo-xu nuo-xu merged commit d5276e8 into development Apr 27, 2023
@nuo-xu nuo-xu deleted the wallet/asset-store-unit-tests branch April 27, 2023 21:11
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7326: Add unit tests for update in asset detail s…
d2904ba 
…tore (brave/brave-ios#7351)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees

@nuo-xu nuo-xu

Labels
None yet
Projects
None yet
Milestone
1.51
Development

Successfully merging this pull request may close these issues.

Unit test Asset Detail Store update function
3 participants
@nuo-xu @StephenHeaps @iccub