Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7219, Fix #7221: Adjust copy Rewards settings & Rewards internals #7342

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix #7219, Fix #7221: Adjust copy Rewards settings & Rewards internals #7342

merged 1 commit into from
Apr 27, 2023

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #7219
This pull request fixes #7221

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner April 26, 2023 21:20
@kylehickinson kylehickinson added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Apr 27, 2023
@kylehickinson kylehickinson removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Apr 27, 2023
@kylehickinson kylehickinson enabled auto-merge (squash) April 27, 2023 14:53
@kylehickinson kylehickinson added this to the 1.51 milestone Apr 27, 2023
@kylehickinson kylehickinson merged commit 3e85253 into development Apr 27, 2023
@kylehickinson kylehickinson deleted the rewards-internals-copy branch April 27, 2023 15:10
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7219, Fix brave/brave-ios#7221: Adjust copy Rewar…
3b70015 
…ds settings & Rewards internals (brave/brave-ios#7342)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soner-yuksel soner-yuksel soner-yuksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.51
2 participants
@kylehickinson @soner-yuksel