Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7255: VPN Protocol (Tunnel) Option #7334

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Fix #7255: VPN Protocol (Tunnel) Option #7334

merged 6 commits into from
Apr 28, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Apr 25, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #7255

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • VPN Settings
  • Check Transport Protocol options
  • Swap

Screenshots:

RPReplay_Final1682618127.MP4

1 3 4 2 1 2 4 3

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner April 25, 2023 21:21
@soner-yuksel soner-yuksel self-assigned this Apr 25, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/vpn-settings-protocol branch 3 times, most recently from be935aa to b3d05f9 Compare April 26, 2023 16:06
iccub
iccub suggested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Left 2 runtime review comments in DM

@soner-yuksel soner-yuksel force-pushed the enhancement/vpn-settings-protocol branch from dcaa92a to b8a03c2 Compare April 27, 2023 17:08
@soner-yuksel
Copy link
Contributor Author

Code looks good. Left 2 runtime review comments in DM

The problem with settings cell detail text is fixed and protocol choice is added to user support email detail.

@soner-yuksel soner-yuksel requested a review from iccub April 27, 2023 18:09
@iccub iccub added this to the 1.51 milestone Apr 28, 2023
@soner-yuksel soner-yuksel merged commit 87e7718 into development Apr 28, 2023
@soner-yuksel soner-yuksel deleted the enhancement/vpn-settings-protocol branch April 28, 2023 14:30
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#7255: VPN Protocol (Tunnel) Option (brave/brave-i…
0eac08c 
…os#7334)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: VPN
Projects
None yet
Milestone
1.51
Development

Successfully merging this pull request may close these issues.

VPN Protocol (Tunnel) Option
2 participants
@soner-yuksel @iccub