This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 445
Fix #7360: Add non-aggressive cosmetic filters #7333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuba
force-pushed
the
js/non-agressive-cosmetic-filters
branch
6 times, most recently
from
April 28, 2023 18:45
f28bac9
to
7c0fe1d
Compare
cuba
changed the title
Add non-aggressive cosmetic filters
Fix #7352: Add non-aggressive cosmetic filters
Apr 28, 2023
cuba
changed the title
Fix #7352: Add non-aggressive cosmetic filters
Fix #7360: Add non-aggressive cosmetic filters
Apr 28, 2023
cuba
force-pushed
the
js/non-agressive-cosmetic-filters
branch
3 times, most recently
from
May 4, 2023 15:38
e5a6bf2
to
be92be8
Compare
iccub
reviewed
May 5, 2023
.../Frontend/UserContent/UserScripts/Scripts_Dynamic/Scripts/Sandboxed/SelectorsPollerScript.js
Show resolved
Hide resolved
Brandon-T
approved these changes
May 5, 2023
cuba
force-pushed
the
js/non-agressive-cosmetic-filters
branch
from
May 8, 2023 10:36
be92be8
to
a01fcc2
Compare
pes10k
reviewed
May 8, 2023
.../Frontend/UserContent/UserScripts/Scripts_Dynamic/Scripts/Sandboxed/SelectorsPollerScript.js
Outdated
Show resolved
Hide resolved
pes10k
suggested changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let a requested change for how to correctly resolve URLs
cuba
force-pushed
the
js/non-agressive-cosmetic-filters
branch
from
May 10, 2023 14:52
a01fcc2
to
eb42862
Compare
iccub
approved these changes
May 10, 2023
pes10k
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
iccub
pushed a commit
that referenced
this pull request
May 16, 2023
iccub
pushed a commit
that referenced
this pull request
May 16, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
…brave-ios#7333) * Add non-aggressive cosmetic filters Undo * Make default ad-block level standard * Fix issue with extracting origin on selectors poller script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #7360
This adds code to support standard mode but until UI is available, we cannot enable it. For this ticket we are testing for unchanged (aggressive) cosmetic filters. Standard mode can only be enabled through code changes for the time being and will be tested once the UI is ready. The UI is done in the following issue: #7352
Note: The logs will be removed before merging. Feel free to leave a comment but it will be the last thing I will do because it is difficult to test scripts in webkit.
Submitter Checklist:
NSLocalizableString()
Test Plan:
NOTE: These tests are also covered here which will be deployed together with this PR. You can skip these tests here as they duplicated there.
Note: Without the UI here the script is set to standard mode. You cannot test aggressive mode without this code merged.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement