Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix: #7240 Add Release Notes for iOS Release 1.49 #7246

Merged
merged 7 commits into from
Apr 15, 2023
Merged

Fix: #7240 Add Release Notes for iOS Release 1.49 #7246

merged 7 commits into from
Apr 15, 2023

Conversation

Uni-verse
Copy link
Contributor

Summary of Changes

This pull request fixes #7240

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

N/A

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Uni-verse Uni-verse added this to the 1.49 milestone Apr 13, 2023
@Uni-verse Uni-verse requested a review from a team as a code owner April 13, 2023 22:17
@Uni-verse Uni-verse self-assigned this Apr 13, 2023
srirambv
srirambv suggested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the first release notes PR. Few changes required as mentioned. Also please add a fullstop . at the end of each line to maintain consistency.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Uni-verse Uni-verse requested a review from srirambv April 14, 2023 15:43
srirambv
srirambv approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ lgtm. good work 👍

kjozwiak
kjozwiak suggested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but really good job @Uni-verse 👌

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Uni-verse Uni-verse requested a review from kjozwiak April 14, 2023 21:14
kjozwiak
kjozwiak approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Awesome, work. Lets get it merged.

@iccub iccub merged commit 95fccb8 into development Apr 15, 2023
@iccub iccub deleted the smesher-relnotes-1.49 branch April 15, 2023 08:01
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@Uni-verse
Fix: brave/brave-ios#7240 Add Release Notes for iOS Release 1.49 (bra…
61c4d8b 
…ve/brave-ios#7246)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srirambv srirambv srirambv approved these changes

@iccub iccub iccub approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Uni-verse Uni-verse

Labels
CI/skip QA/No release-notes/exclude
Projects
None yet
Milestone
1.49
Development

Successfully merging this pull request may close these issues.

Release Notes for iOS Release 1.49
4 participants
@Uni-verse @kjozwiak @iccub @srirambv