Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7213, #4187: Block Playlist from showing up on Brave-Talk #7214

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Apr 6, 2023

Summary of Changes

  • Block playlist from showing up entirely, on Brave-Talk

This pull request fixes #7213, #4187

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.50 milestone Apr 6, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner April 6, 2023 15:50
@Brandon-T Brandon-T self-assigned this Apr 6, 2023
@iccub iccub enabled auto-merge (squash) April 6, 2023 15:55
@Brandon-T Brandon-T changed the title Fix #7213: Block Playlist from showing up on Brave-Talk Fix #7213, #4187: Block Playlist from showing up on Brave-Talk Apr 6, 2023
@soner-yuksel soner-yuksel force-pushed the bugfix/PlaylistBlacklist branch from 344a230 to ca7408e Compare April 6, 2023 18:09
@iccub iccub merged commit 3a105e9 into development Apr 6, 2023
@iccub iccub deleted the bugfix/PlaylistBlacklist branch April 6, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature-Request] Block Playlist from showing up on Brave-Talk
3 participants