Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7114: Drop tmp directory on launch when it exceeds a size threshold #7210

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

kylehickinson
Copy link
Collaborator

This replaces the webkit folder cleanup, but we could technically have both if we need

Summary of Changes

This pull request fixes #7114

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan

For simulator testing:

  • Get the tmp folder directory and open it in Finder
  • Launch the app and verify it doesn't get removed & re-added
  • Create a file in the tmp directory that exceeds the size limit (100MB). (example command to do so: $ dd if=/dev/zero of=/path/to/tmp/test.dat bs=150M count=1)
  • Re-launch app and see the app size drop

For in-app testing:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner April 5, 2023 18:27
@iccub iccub added this to the 1.50 milestone Apr 6, 2023
@iccub iccub merged commit 4446cc2 into development Apr 6, 2023
@iccub iccub deleted the tmp-cleanup-pt2 branch April 6, 2023 15:25
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop contents of "tmp" folder at app launch
3 participants