Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6967: Use constants provided by core for Solana Instruction Decoding #7187

Merged

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Small code re-use now that these String constants are available via core.

This pull request fixes #6967

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Verify code changes matches up with new constants: https://github.com/brave/brave-core/blob/master/components/brave_wallet/common/brave_wallet.mojom#L1678-L1685

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps requested a review from nuo-xu April 3, 2023 13:51
@StephenHeaps StephenHeaps self-assigned this Apr 3, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner April 3, 2023 13:51
@StephenHeaps StephenHeaps added this to the 1.50 milestone Apr 3, 2023
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@StephenHeaps StephenHeaps enabled auto-merge (squash) April 3, 2023 14:17
@StephenHeaps StephenHeaps merged commit c36995b into development Apr 3, 2023
@StephenHeaps StephenHeaps deleted the wallet/solana-instruction-decoding-constants branch April 3, 2023 14:27
Brandon-T pushed a commit that referenced this pull request Apr 11, 2023
…ding (#7187)

Use constants provided by core for Solana Instruction Decoding
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…nstruction Decoding (brave/brave-ios#7187)

Use constants provided by core for Solana Instruction Decoding
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shared constants from core in Solana Instruction decoding
3 participants