Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6357: Support v2 SKU credentials and add expiration check logic #6397

Merged
merged 15 commits into from
Nov 24, 2022
Merged

Fix #6357: Support v2 SKU credentials and add expiration check logic #6397

merged 15 commits into from
Nov 24, 2022

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Nov 15, 2022 •
edited
Loading

Summary of Changes

This pull request fixes #6357

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

iccub
iccub commented Nov 15, 2022
View reviewed changes
App/iOS/Delegates/SceneDelegate.swift Show resolved Hide resolved
Client/BraveSkus/BraveSkusManager.swift Show resolved Hide resolved
Client/BraveSkus/BraveSkusManager.swift Show resolved Hide resolved
Client/BraveSkus/BraveSkusManager.swift Outdated Show resolved Hide resolved
Client/BraveSkus/BraveSkusManager.swift Outdated Show resolved Hide resolved
Client/BraveSkus/BraveSkusManager.swift Show resolved Hide resolved
Client/BraveSkus/BraveSkusWebHelper.swift Show resolved Hide resolved
Client/Frontend/Browser/BrowserViewController.swift Show resolved Hide resolved
...nd/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/BraveSkusScriptHandler.swift Show resolved Hide resolved
Sources/BraveVPN/BraveVPN.swift Show resolved Hide resolved
@iccub iccub marked this pull request as ready for review November 15, 2022 22:12
@iccub iccub requested a review from bsclifton November 15, 2022 22:13
@iccub iccub changed the title Bugfix/6357 Fix #6357: Support v2 SKU credentials and add expiration check logic Nov 15, 2022
bsclifton
bsclifton reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - let me know what you think 🙂

@iccub iccub force-pushed the bugfix/6357 branch 2 times, most recently from 82a803e to 57a23f8 Compare November 18, 2022 21:18
@iccub iccub requested a review from bsclifton November 19, 2022 10:03
@iccub iccub requested review from a team and removed request for a team November 21, 2022 20:46
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 21, 2022
@iccub
Copy link
Contributor Author

iccub commented Nov 21, 2022

blocked: working on updating incorrect logic regarding credential summary

@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 21, 2022
@iccub iccub requested a review from a team November 21, 2022 21:42
@iccub iccub added this to the 1.46 milestone Nov 24, 2022
@iccub iccub merged commit fc54888 into development Nov 24, 2022
@iccub iccub deleted the bugfix/6357 branch November 24, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@iccub iccub

Labels
None yet
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

Update cross platform vpn logic for v2 credentials
3 participants
@iccub @kylehickinson @bsclifton