This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #463: Fixes resolution issue in the favorites view #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhreis
reviewed
Jan 18, 2019
| @@ -67,9 +67,10 @@ class FavoritesDataSource: NSObject, UICollectionViewDataSource { | |||
| guard let fav = frc?.object(at: indexPath) else { return UICollectionViewCell() } | |||
|
|
|||
| cell.textLabel.text = fav.displayTitle ?? fav.url | |||
| cell.imageView.setIcon(fav.domain?.favicon, forURL: URL(string: fav.url ?? ""), scaledDefaultIconSize: CGSize(width: 40, height: 40), completed: { (color, url) in | |||
| let n: FaviconMO? = nil // Distinguishes which setIcon function is called | |||
There was a problem hiding this comment.
This is kind of an interesting workaround, however, there should be a more determined solution than using a typed optional set to nil to choose the function. One option would be to give the setIcon function different declarations/names, to avoid overloading and calling the wrong function.
|
The function names have been changed to help distinguish them. Let me know if there's anything else to fix :) |
jhreis
approved these changes
Mar 4, 2019
|
Thanks bunches! Really appreciate the work on this, and thanks for your huge patience with us 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
My patch has gone through review and I have addressed review comments
My patch has a standard commit message that looks like
Fix #123: This fixes the shattered coffee cup!I have updated the Unit Tests to cover new or changed functionality
I have updated the UI Tests to cover new or changed functionality
I have marked the bug with
[needsuplift]I have made sure that localizable strings use
NSLocalizableString()Screenshots
Notes for testing this patch
Fixes issue 463
The issue stems from passing in a non-nil icon value into the setIcon function which uses that image as an upscale instead of using the FaviconFetcher.