This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #5860: Add window.caches blocking when cookie blocking is enabled
#5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
approved these changes
Aug 15, 2022
iccub
force-pushed
the
js/5860-window.caches-blocking
branch
from
9e6f4bc
to
c8ba4e8
Compare
cuba
requested review from
diracdeltas and
thypon
and removed request for
diracdeltas
diracdeltas
reviewed
Aug 15, 2022
cuba
force-pushed
the
js/5860-window.caches-blocking
branch
from
c8ba4e8
to
72f53d2
Compare
cuba
force-pushed
the
js/5860-window.caches-blocking
branch
2 times, most recently
from
14faaa4
to
0ca193e
Compare
Brandon-T
approved these changes
Aug 15, 2022
thypon
approved these changes
Aug 15, 2022
iccub
force-pushed
the
js/5860-window.caches-blocking
branch
2 times, most recently
from
41d2705
to
e2e6ca0
Compare
iccub
force-pushed
the
js/5860-window.caches-blocking
branch
from
e2e6ca0
to
6e3ad99
Compare
iccub
pushed a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Block
window.cachesAPI when cookie blocking is enabledThis pull request fixes #5860
Submitter Checklist:
NSLocalizableString()Test Plan:
You may use the the following test page: https://dev-pages.brave.software/storage/dom-storage.html
Note when cookie blocking is enabled, all frames should show "false"
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement