Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5472: Generate identical blockies as other Brave platforms #5473

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix #5472: Generate identical blockies as other Brave platforms #5473

merged 1 commit into from
Jun 9, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #5472

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.40 milestone Jun 8, 2022
@kylehickinson kylehickinson changed the title Fix #5472: Generate identical blockies from across all Brave platforms Fix #5472: Generate identical blockies as other Brave platforms Jun 8, 2022
@kylehickinson kylehickinson merged commit 06da304 into development Jun 9, 2022
@kylehickinson kylehickinson deleted the blockie-colour-match branch June 9, 2022 02:16
@srirambv srirambv mentioned this pull request Jun 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

@nuo-xu nuo-xu nuo-xu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

Blockie colours don't match other platforms
3 participants
@kylehickinson @nuo-xu @StephenHeaps