Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5268: Farble concurrency #5269

Merged
merged 1 commit into from
May 10, 2022
Merged

Fix #5268: Farble concurrency #5269

merged 1 commit into from
May 10, 2022

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Apr 20, 2022

Summary of Changes

Farble window.navigator.hardwareConcurrency to be a value between 2 and the true value:

  1. Added additional scripts to FarblingProtection.js
  2. Added random values injected to that script to farbling protection script in FarblingProtectionHelper.swift

This pull request fixes #5268

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Test plan can be found in the provided issue.

Screenshots:

N/A

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team April 21, 2022 23:58
@cuba cuba merged commit 750ac91 into development May 10, 2022
@cuba cuba deleted the js/5268-farble-concurrency branch May 10, 2022 19:44
@iccub iccub added this to the 1.39 milestone May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: hardwareConcurrency
3 participants